i2c: bcm2835: Protect against unexpected TXW/RXR interrupts
authorNoralf Trønnes <noralf@tronnes.org>
Fri, 23 Sep 2016 16:24:38 +0000 (18:24 +0200)
committerRaspbian kernel package updater <root@raspbian.org>
Thu, 15 Feb 2018 17:28:33 +0000 (17:28 +0000)
commitbfea324005a15748f3855aac538ea9b849b2c1fa
tree83e72284a08f73162f5a26c0f78cc5e5a29c8b61
parentde7399e6c564ff0eba763503f6c729016335ce35
i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0),
the driver has no way to fill/drain the FIFO to stop the interrupts.
In this case the controller has to be disabled and the transfer
completed to avoid hang.

(CLKT | ERR) and DONE interrupts are completed in their own paths, and
the controller is disabled in the transfer function after completion.
Unite the code paths and do disabling inside the interrupt routine.

Clear interrupt status bits in the united completion path instead of
trying to do it on every interrupt which isn't necessary.
Only CLKT, ERR and DONE can be cleared that way.

Add the status value to the error value in case of TXW/RXR errors to
distinguish them from the other S_LEN error.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
drivers/i2c/busses/i2c-bcm2835.c